git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git reset for index restoration?

From
Junio C Hamano <gitster@pobox.com>
Date
May 22, 2014, 22:12 UTC
Message-ID
<xmqq61kxmphw.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1400796077.18134.41.camel@stross>
David Turner <dturner@twopensource.com> writes:
Show 5 quoted lines
>> Yes.  As I said, that should not usually be a problem for those who
>> do the real work (read: commit), at which time write-tree will fully
>> populate the cache-tree.
>
> Git commit does not in fact populate the cache-tree.

If that is the case, we must have broken the write-tree codepath over time.

Of course, "git commit foo" will need to prepare a temporary index where only the entry "foo" is different from the HEAD version, write the tree to create a commit, but we do not write out the main index as a tree after updating the same entry "foo" in it (there may be other changes relative to HEAD), so its cache-tree is only invalidated at "foo" when we updating the entry and we do not spend extra cycles to repopulate it.

But at least my understanding has been that "git commit" (no partial commit, write the whole index as a commit) which uses the "git write-tree" machinery knows which subtree has what tree object name and populates the cache-tree fully.

Previous: David TurnerNext: Junio C Hamano
Message 16 of 22 in “git reset for index restoration?”
  1. David TurnerMay 22, 2014
  2. Jeff KingMay 22, 2014
  3. David TurnerMay 22, 2014
  4. Jeff KingMay 22, 2014
  5. David TurnerMay 22, 2014
  6. Elijah NewrenMay 22, 2014
  7. David TurnerMay 22, 2014
  8. Jeff KingMay 22, 2014
  9. David TurnerMay 22, 2014
  10. Jeff KingMay 22, 2014
  11. Jeff KingMay 22, 2014
  12. Junio C HamanoMay 22, 2014
  13. David TurnerMay 22, 2014
  14. Junio C HamanoMay 22, 2014
  15. David TurnerMay 22, 2014
  16. Junio C HamanoMay 22, 2014
  17. Junio C HamanoMay 22, 2014
  18. Duy NguyenMay 22, 2014
  19. David TurnerMay 22, 2014
  20. Junio C HamanoMay 22, 2014
  21. David TurnerMay 22, 2014
  22. Junio C HamanoMay 22, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.