Re: [PATCH] compat-util: add _DEFAULT_SOURCE define
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2014, 19:02 UTC
- Message-ID
- <xmqq61go7lme.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1410672815-2555-1-git-send-email-sergey.senozhatsky@gmail.com>
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> writes:
Show 8 quoted lines
> glibc has deprecated the use of _BSD_SOURCE define > > warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" > > To make it easier to maintain a cross platform source code, that > warning can be suppressed by _DEFAULT_SOURCE. > > Define both _BSD_SOURCE, _DEFAULT_SOURCE and cleanup the build.
I can see you defined DEFAULT_SOURCE, but where did you do "cleanup the build"? Or did you mean "define both (in order) to clean up"?
Just making sure we are not only seeing a patch half eaten by mail transport somewhere.
Show 17 quoted lines
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > --- > git-compat-util.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/git-compat-util.h b/git-compat-util.h > index 4e7e3f8..08a9ee2 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -82,6 +82,7 @@ > #define _ALL_SOURCE 1 > #define _GNU_SOURCE 1 > #define _BSD_SOURCE 1 > +#define _DEFAULT_SOURCE 1 > #define _NETBSD_SOURCE 1 > #define _SGI_SOURCE 1