Re: [PATCH 08/16] t5304: use helper to report failure of "test foo = bar"
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> Based on your responses, I'm leaning towards:
>
> test_cmp_str() {
> test "$@" && return 0
> echo >&2 "command failed: test $*"
> return 1
> }
>
> since the point is really just to print _something_ when the test fails
> (any quoting or whitespace may be wrong, of course, but that's OK; it's
> for human consumption, and is just a hint).If we really cared, we could do
echo >&2 "command failed: test $(git rev-parse --sq-quote "$@")"
perhaps?
Junio C Hamano <gitster@pobox.com>