[PATCH] run-command.c: retire unused run_hook_with_custom_index()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 1, 2014, 16:43 UTC
- Message-ID
- <xmqq61dvqq12.fsf@gitster.dls.corp.google.com>
This was originally meant to be used to rewrite run_commit_hook() that only special cases the GIT_INDEX_FILE environment, but the run_hook_ve() refactoring done earlier made the implementation of run_commit_hook() thin and clean enough.
Nobody uses this, so retire it as an unfinished clean-up made unnecessary.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- run-command.c | 17 ----------------- run-command.h | 4 ---- 2 files changed, 21 deletions(-)
diff --git a/run-command.c b/run-command.c index 35a3ebf..ae36852 100644 --- a/run-command.c +++ b/run-command.c @@ -792,20 +792,3 @@ int run_hook_le(const char *const *env, const char *name, ...) return ret; } - -int run_hook_with_custom_index(const char *index_file, const char *name, ...) -{ - const char *hook_env[3] = { NULL }; - char index[PATH_MAX]; - va_list args; - int ret; - - snprintf(index, sizeof(index), "GIT_INDEX_FILE=%s", index_file); - hook_env[0] = index; - - va_start(args, name); - ret = run_hook_ve(hook_env, name, args); - va_end(args); - - return ret; -} diff --git a/run-command.h b/run-command.h index ea73de3..9e8cd9c 100644 --- a/run-command.h +++ b/run-command.h @@ -53,10 +53,6 @@ LAST_ARG_MUST_BE_NULL extern int run_hook_le(const char *const *env, const char *name, ...); extern int run_hook_ve(const char *const *env, const char *name, va_list args); -LAST_ARG_MUST_BE_NULL -__attribute__((deprecated)) -extern int run_hook_with_custom_index(const char *index_file, const char *name, ...); - #define RUN_COMMAND_NO_STDIN 1 #define RUN_GIT_CMD 2 /*If this is to be git sub-command */ #define RUN_COMMAND_STDOUT_TO_STDERR 4
-- 2.2.0-133-g5229807