git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] reachable: only mark local objects as recent

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 17, 2015, 17:18 UTC
Message-ID
<xmqq618ur7un.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150417132824.GA13192@peff.net>
Jeff King <peff@peff.net> writes:
Show 26 quoted lines
> On Fri, Mar 27, 2015 at 12:00:05PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > It is possible that we may drop an object that is depended
>> > upon by another object in the alternate. For example,
>> > imagine two repositories, A and B, with A pointing to B as
>> > an alternate. Now imagine a commit that is in B which
>> > references a tree that is only in A. Traversing from recent
>> > objects in B might prevent A from dropping that tree. But
>> > this case isn't worth covering. Repo B should take
>> > responsibility for its own objects. It would never have had
>> > the commit in the first place if it did not also have the
>> > tree, and assuming it is using the same "keep recent chunks
>> > of history" scheme, then it would itself keep the tree, as
>> > well.
>> 
>> In other words, if you have a loop in dependency chain among
>> alternate repositories, your set-up is broken by definition.
>> 
>> Which makes sense to me.
>> 
>> Thanks.
>
> I don't see this patch in "pu" or "What's Cooking" at all. Did it get
> dropped?

It appears that way (rather, "never picked up"). Thanks for reminding.

>
> It does fix a performance regression, but the problem is in v2.2, so I
> don't think it's urgent for v2.4-rc.
Previous: Jeff King
Message 4 of 4 in “reachable: only mark local objects as recent”
  1. reachable: only mark local objects as recentJeff King, Mar 27, 2015
  2. Junio C HamanoMar 27, 2015
  3. Jeff KingApr 17, 2015
  4. Junio C HamanoApr 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.