git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/4] submodule config lookup API

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 12, 2015, 19:27 UTC
Message-ID
<xmqq614kl33d.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1439406838-6290-1-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
> However just as I was convinced of my review and sent out the email, I started
> working with it. And I found nits which I'd ask you to squash into the round or
> put on top.

Good ;-). I'd prefer a full reroll, as it has been quite a while since v5 was originally posted, once you get to a reasonable state where you are reasonably confident that you won't find more of such nits. Hopefully more people might have eyes on the list to review and comment this round.

Thanks.
Previous: Eric Sunshine
Message 7 of 7 in “Re: [PATCH v5 0/4] submodule config lookup API”
  1. Stefan BellerAug 12, 2015
  2. 1/2 Fixup hv/documentationStefan Beller, Aug 12, 2015
  3. 2/2 cleanup submodule_config a bit.Stefan Beller, Aug 12, 2015
  4. Eric SunshineAug 12, 2015
  5. Stefan BellerAug 12, 2015
  6. Eric SunshineAug 12, 2015
  7. Junio C HamanoAug 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.