Re: [PATCH] graph.c: visual difference on subsequent series

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 3, 2015, 17:13 UTC
Message-ID: <xmqq613rl92s.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <55E7FEF3.2020400@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 6 quoted lines

>> Is the design of your independent implementation the same except
>> that 'o' is used instead of 'x'?  Independent implementation does
>> not make the same design magically better, if that is the case ;-)
>
> Interestingly, the patch to the tests lists * to o changes only, no < or
>> to o.

Well, in that case, then the opposite but an equivalent problem exists in the design, no? It promises to make roots stand out by painting them as 'o', but it sometimes fails to do so. In other words, ...

> The reason is simply that the patch doesn't change anything for left nor
> right commits. I would say that is the best compromise since it does not
> change the overall layout, provides more information by default and does
> not override information that is requested specifically.

... it fails your last criteria.

> If we want to put more information into log --graph simultaneously we
> should really go beyond ASCII and look at how tig does it, e.g. using
> unicode characters.

That's another way to do so, but shifting columns to show where the history is not connected also does not change the overall layout, provides more information by default, etc., and a big plus is that it would be an approach to do so without having to go beyond ASCII.