Re: [PATCH] rebase: add --verify-signatures

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 17, 2015, 18:22 UTC
Message-ID: <xmqq60zxc4v7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20151217010422.GA19500@blarch>

Alexander 'z33ky' Hirsch <1zeeky@gmail.com> writes:

> As I understand it, this is the same reason for the existence of
> --verify-signatures for git-merge. Otherwise the same argument could be
> made for git-merge

I suspect that you are missing the bigger workflow issues, if you think this and merge are the same.

git-merge will check the other history on the side branch that you are merging _into_ the trunk, to give you an opportunity to reject what does not pass and keep the trunk sane without doing anything else. How you (or others who asked you to pull) clean up the side branch is outside the scope of its verification.

Your change to "git pull --rebase" checks the other way---the history, which is already the trunk, onto which your work will be rebased. There is nothing you can do without messing with the trunk if the validation did not pass, be it with a rewind-and-rebuild or a sealing empty commit which is pointless.