Re: [PATCH] document how to reference previous commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 28, 2016, 15:38 UTC
- Message-ID
- <xmqq60rpu61h.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160728125514.GA2813@sandbox>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 9 quoted lines
> @@ -121,6 +121,11 @@ its behaviour. Try to make sure your explanation can be understood > without external resources. Instead of giving a URL to a mailing list > archive, summarize the relevant points of the discussion. > > +If you want to reference a previous commit in the history of a stable > +branch use the format "abbreviated sha1 (subject, date)". So for example > +like this: "Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30) > +noticed [...]". > +
I earlier said that our goal should not be to spell out all the conventions, which would lead to unreadably long document, but this does not look too bad. Small additions however tend to accumulate over time, though ;-)
I wondered if we need to also say "why", but we probably shouldn't.
Thanks.