Re: SubmittingPatches: drop temporal reference for PGP signing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 27, 2017, 17:43 UTC
- Message-ID
- <xmqq60l01jr9.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <60e9abdf-cc37-33d8-e7eb-8a3370ffe1cc@tngtech.com>
Cornelius Weig <cornelius.weig@tngtech.com> writes:
> -Do not PGP sign your patch, -at least for now-. Most likely, your (...) > +Do not PGP sign your patch. Most likely, your maintainer or other (...)
It has been quite a while since we wrote that "at least for now", so it probably makes sense to drop it.
Show 12 quoted lines
>> Maybe even s/by signing off/by adding your Signed-off-by:/ to be sure >> that the reader knows that it is _their certification_ that is being >> sought. Even if it does double up on the 'your'. > > I don't think doubling on the 'your' will make the heading clearer. The > main intention of this change is to avoid mixups with pgp-signing and > that would IMHO not improve by that. > Besides, I find the colon in the heading a bit awkward. Is the following > version as expressive as with the colon? > > -(5) Sign your work > +(5) Certify your work by adding Signed-off-by
I am leaning towards agreeing with Philip, and my gut feeling says the presense of the colon, would help a lot. It would visually click to readers what we are talking about.
At the same time, I think ending a section header with a colon would be seen as "awkward". I would have written it more like this to avoid it:
... by adding "Signed-off-by: " line
I personally do not mind having "your" there, either, but I can see that a section header wants to be kept shorter.