Re: [PATCH] doc: update SubmittingPatches

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2017, 02:36 UTC
Message-ID: <xmqq60hu351w.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1492964264-29423-1-git-send-email-liebundartig@freenet.de>

René Genz <liebundartig@freenet.de> writes:

 (updates for minor irritations skipped as I do not have strong
 opinions against them).

Show 6 quoted lines

> @@ -261,7 +261,7 @@ smaller project it is a good discipline to follow it.
>  The sign-off is a simple line at the end of the explanation for
>  the patch, which certifies that you wrote it or otherwise have
>  the right to pass it on as a open-source patch.  The rules are
> -pretty simple: if you can certify the below:
> +pretty simple: if you can certify the below D-C-O:

OK. There is another instance of D-C-O away from here and new people who read the document would not know without this addition what it refers to. This is a good addition.

Show 5 quoted lines

>          Developer's Certificate of Origin 1.1
>  
> @@ -376,6 +376,25 @@ from the list and queue it to 'pu', in order to make it easier for
>  people play with it without having to pick up and apply the patch to
>  their trees themselves.

An oversimplified one is not necessarily welcome. Can you split this patch into "fixes" (all of the above) and the remainder?

>  
> +
> +An oversimplified summary of the commands to run:

Show 19 quoted lines

> +* clone repo
> +  $ git clone https://github.com/git/git
> +
> +* change files in your local repo copy
> +
> +* commit your changes
> +  $ git commit -a
> +
> +* create '.patch' file for the latest commit
> +  $ git format-patch HEAD^
> +
> +* install 'git-email' package and configure it, f.e.
> +    https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/
> +  send an email to yourself using your MUA in order to find out the value
> +  for the "--smtp-domain" option; look at the 'Received' header option
> +  $ git send-email --annotate --smtp-domain=LONGSTRING --to=git@vger.kernel.org --cc=MAINTAINER --smtp-debug=1 NAME.patch
> +
>  ------------------------------------------------
>  Know the status of your patch after submission