git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7] read-cache: force_verify_index_checksum

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 26, 2017, 03:25 UTC
Message-ID
<xmqq60hru9xg.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<alpine.DEB.2.20.1704252225450.3480@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
> Just in case that certain reviewers favor length over readability, let me
> offer this snippet:
>
> 	size=$(perl -e "print -s \".git/index\"") &&
> 	dd if=/dev/zero of=.git/index bs=1 seek=$(($size-20) count=20

Yup, this does sound like a good direction to go (I think you have some unbalanced parens but it is sufficient to convey the idea).

> Since whatever hash will be used in the future is most likely larger than
> 20 bytes, this should still work fine (and even if somebody sane replaces
> the SHA-1 of the index with a CRC-32 for the same benefit we have now, the
> test will fail quickly and it is easy to replace the 20 by 4).
True that, too.
Previous: Johannes SchindelinNext: Christian Couder
Message 7 of 13 in “read-cache: call verify_hdr() in a background thread”
  1. read-cache: call verify_hdr() in a background threadgit@jeffhostetler.com, Apr 14, 2017
  2. read-cache: force_verify_index_checksumgit@jeffhostetler.com, Apr 14, 2017
  3. Johannes SixtApr 24, 2017
  4. Jeff HostetlerApr 24, 2017
  5. Junio C HamanoApr 25, 2017
  6. Johannes SchindelinApr 25, 2017
  7. Junio C HamanoApr 26, 2017
  8. Christian CouderMay 8, 2017
  9. Jeff HostetlerMay 8, 2017
  10. Christian CouderMay 8, 2017
  11. Jeff HostetlerMay 8, 2017
  12. Junio C HamanoMay 9, 2017
  13. Junio C HamanoMay 9, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.