git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] wildmatch test: cover a blind spot in "/" matching

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 15, 2017, 22:01 UTC
Message-ID
<xmqq60fwzz9y.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170615211041.22768-1-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 13 quoted lines
> A negated character class that does not include '/', e.g. [^a-z]:
>
>  - Should match '/' when doing "wildmatch"
>  - Should not match '/' when doing "pathmatch"
>
> Add two tests to cover these cases.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>
> Now with updated commit message, no other changes. Sorry about the
> delay.
Thanks.  I completely forgot about this topic ;-)
Show 24 quoted lines
>
>  t/t3070-wildmatch.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
> index 7ca69f4bed..8fd70d3aa2 100755
> --- a/t/t3070-wildmatch.sh
> +++ b/t/t3070-wildmatch.sh
> @@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'
>  match 1 0 'foo/bar' 'foo/**/**/bar'
>  match 0 0 'foo/bar' 'foo?bar'
>  match 0 0 'foo/bar' 'foo[/]bar'
> +match 0 0 'foo/bar' 'foo[^a-z]bar'
>  match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
>  match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
>  match 1 0 'foo' '**/foo'
> @@ -225,6 +226,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'
>  pathmatch 0 foo/bba/arr 'foo/**z'
>  pathmatch 1 foo/bar 'foo?bar'
>  pathmatch 1 foo/bar 'foo[/]bar'
> +pathmatch 1 foo/bar 'foo[^a-z]bar'
>  pathmatch 0 foo '*/*/*'
>  pathmatch 0 foo/bar '*/*/*'
>  pathmatch 1 foo/bba/arr '*/*/*'
Previous: Ævar Arnfjörð Bjarmason
Message 2 of 2 in “wildmatch test: cover a blind spot in "/" matching”
  1. wildmatch test: cover a blind spot in "/" matchingÆvar Arnfjörð Bjarmason, Jun 15, 2017
  2. Junio C HamanoJun 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.