Re: [PATCH] pathspec: die on empty strings as pathspec
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 23, 2017, 04:46 UTC
- Message-ID
- <xmqq60fngvky.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqefubgxa3.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Emily Xie <emilyxxie@gmail.com> writes: > >> I ran the tests and none of them failed. > > This is not about a test you touched, but applied to or merged to > any of the recent integration branches (like 'master' or 'maint') > > $ make > $ cd t > $ GIT_TEST_LONG=YesPlease sh ./t0027-*.sh > > fails at the very beginning. I do not know if 0027 is the only one > that triggers this failure, though.
t0027 should pass with this, I think.
I am not sure if we even want the dot there, but at least that is what the original author of the test intended to do when s/he decided to pass an empty string as the pathspec.
t/t0027-auto-crlf.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh index 93725895a4..e41c9b3bb2 100755 --- a/t/t0027-auto-crlf.sh +++ b/t/t0027-auto-crlf.sh @@ -322,7 +322,7 @@ test_expect_success 'setup master' ' echo >.gitattributes && git checkout -b master && git add .gitattributes && - git commit -m "add .gitattributes" "" && + git commit -m "add .gitattributes" . && printf "\$Id: 0000000000000000000000000000000000000000 \$\nLINEONE\nLINETWO\nLINETHREE" >LF && printf "\$Id: 0000000000000000000000000000000000000000 \$\r\nLINEONE\r\nLINETWO\r\nLINETHREE" >CRLF && printf "\$Id: 0000000000000000000000000000000000000000 \$\nLINEONE\r\nLINETWO\nLINETHREE" >CRLF_mix_LF &&