git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] make get_be64() compile on pu with NO_UNALIGNED_LOADS

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 22, 2017, 15:54 UTC
Message-ID
<xmqq60ekfow8.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170722094717.16305-1-martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> Applies to pu and passes the tests. I think this should be squashed in
> somewhere. Perhaps a mismerge in commit d553324d ("Merge branch
> 'bp/fsmonitor' into pu", 2017-07-21).
Yes, you spotted a mistaken evil-merge.  Thanks.
Show 23 quoted lines
>
>  compat/bswap.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/compat/bswap.h b/compat/bswap.h
> index 133da1d2b..f86110a72 100644
> --- a/compat/bswap.h
> +++ b/compat/bswap.h
> @@ -188,11 +188,11 @@ static inline void put_be32(void *ptr, uint32_t value)
>  	p[3] = value >>  0;
>  }
>  
> -static inline unit64_t get_be64(const void *ptr)
> +static inline uint64_t get_be64(const void *ptr)
>  {
> -	unsigned char *p = ptr;
> +	const unsigned char *p = ptr;
>  	return  ((uint64_t)get_be32(p) << 32) |
> -		((uint64_t)get_be32(p + 4);
> +		((uint64_t)get_be32(p + 4));
>  }
>  
>  #endif
Previous: Martin Ågren
Message 2 of 2 in “make get_be64() compile on pu with NO_UNALIGNED_LOADS”
  1. make get_be64() compile on pu with NO_UNALIGNED_LOADSMartin Ågren, Jul 22, 2017
  2. Junio C HamanoJul 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.