Re: [PATCH] diff.c: offer config option to control ws handling in move detection

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2018, 17:32 UTC
Message-ID: <xmqq601bgmh3.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAGZ79kZvHvMy6Lf-_Dtzbfaz2BFY2WonOfw-dDQVCOnS-a0=sA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 7 quoted lines

> "git format-patch HEAD^ --color" produces red/green output
> (like git log would), so I do not see why --color-moved should impact
> format-patch differently. (i.e. if the user requests format-patch with
> color-moved we can do it, otherwise, when colors are off, we do not
> spend cycles to compute the moves)
>
> Maybe I did not understand the gist of your question, still?

"format-patch --color" done by end-user, especially when combined with "--stdout", would be useful to show coloured output. That is what you are talking about in the above, but that is not what I was asking about.

The question was specifically about configuration. You may say "diff.colorwhatever = on", but "git format-patch" with no command line override wouldn't want to be affected by that and produce a patch that won't apply, I would think.