Re: [Possible GIT Bug]

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2018, 18:37 UTC
Message-ID: <xmqq5zzdtczq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180910173512.GA22152@esm>

"Eckhard Maaß" <eckhard.s.maass@googlemail.com> writes:

Show 13 quoted lines

> On Mon, Sep 10, 2018 at 09:03:10AM -0700, Junio C Hamano wrote:
>> It is neither but if I have to pick one between the two, it is much
>> closer to the former than the latter.  The primary source of this is
>> that we have only *one* pathspec given to the diff machinery, but in
>> order to implement your ideal "find harder", you'd need *two*.  That
>> is, one set of paths for which you are interested in their origin,
>> and the other set that you allow the machinery to consider as possible
>> origins.  Since we can only give one pathspec machinery, that one
>> pathspec is used to specify both of these sets.
>
> How does tihs compare to `--follow`? With that knob active the machinery
> indeed uses the whole repository for finding renames and/or copies. Is
> this the only exception then?

'--follow' is a checkbox hack that is not even properly integrated with the diff machinery (it only exists on the "log" side of the tool), so I do not think it is productive to find a comparison.