Re: [PATCH 1/1] Update .mailmap

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2018, 02:48 UTC
Message-ID: <xmqq5zx76k67.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <b590a9bebf8ac10b6f1d85287bb8d7a8ac7082a6.1541696887.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This patch makes the output of `git shortlog -nse v2.10.0`
> duplicate-free.

Did you mean "v2.10.0..master" or did you really mean this covers authors recorded up to v2.10.0? Judging from the cover letter, I think you meant the former.

Can you say a bit more about how one among multiple addresses for each person was chosen in the log message? E.g. "After asking each author which one is the preferred one", "Picked the one with the most recent committer timestamps", "There were two for each but one of them were bouncing", etc.

Show 5 quoted lines

> @@ -150,6 +155,7 @@ Mark Levedahl <mdl123@verizon.net> <mlevedahl@gmail.com>
>  Mark Rada <marada@uwaterloo.ca>
>  Martin Langhoff <martin@laptop.org> <martin@catalyst.net.nz>
>  Martin von Zweigbergk <martinvonz@gmail.com> <martin.von.zweigbergk@gmail.com>
> +Masaya Suzuki <masayasuzuki@google.com><draftcode@gmail.com>

It is a bit surprising that we can take an entry without SP in between two addresses and still behave sensibley, but it probably makes more sense to add one just to look similar to other entries.

Thanks for working on this.