git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] check-docs: fix for setups where executables have an extension

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 14, 2019, 01:54 UTC
Message-ID
<xmqq5zsmcjaf.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<f06126c3a11119bf6e2a830bbac312f65582387f.1552478212.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> On Windows, for example, executables (must) have the extension `.exe`.
> Our `check-docs` target was not prepared for that.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---

My writing this loop certainly predates increased upstream activities for Windows port we see recently, and we saw little updates ever since the loop was written; I am kind of surprised it took this long for us to find the missing .exe support here.

Thanks.
Show 25 quoted lines
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 537493822b..df56bf0cd1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3074,7 +3074,7 @@ ALL_COMMANDS += git-gui git-citool
>  .PHONY: check-docs
>  check-docs::
>  	$(MAKE) -C Documentation lint-docs
> -	@(for v in $(ALL_COMMANDS); \
> +	@(for v in $(patsubst %$X,%,$(ALL_COMMANDS)); \
>  	do \
>  		case "$$v" in \
>  		git-merge-octopus | git-merge-ours | git-merge-recursive | \
> @@ -3103,7 +3103,7 @@ check-docs::
>  		    -e 's/\.txt//'; \
>  	) | while read how cmd; \
>  	do \
> -		case " $(ALL_COMMANDS) " in \
> +		case "  $(patsubst %$X,%,$(ALL_COMMANDS)) " in \
>  		*" $$cmd "*)	;; \
>  		*) echo "removed but $$how: $$cmd" ;; \
>  		esac; \
Previous: Johannes Schindelin via GitGitGadgetNext: Taylor Blau
Message 3 of 17 in “Fix make check-docs on Windows”
  1. 0/1 Fix make check-docs on WindowsJohannes Schindelin via GitGitGadget, Mar 13, 2019
  2. 1/1 check-docs: fix for setups where executables have an extensionJohannes Schindelin via GitGitGadget, Mar 13, 2019
  3. Junio C HamanoMar 14, 2019
  4. Taylor BlauMar 22, 2019
  5. Johannes SchindelinMar 24, 2019
  6. Junio C HamanoMar 24, 2019
  7. Johannes SchindelinMar 25, 2019
  8. 0/5 Fix make check-docs on WindowsJohannes Schindelin via GitGitGadget, Mar 25, 2019
  9. 3/5 check-docs: really look at the documented commands againJohannes Schindelin via GitGitGadget, Mar 25, 2019
  10. 5/5 check-docs: fix for setups where executables have an extensionJohannes Schindelin via GitGitGadget, Mar 25, 2019
  11. 2/5 docs: do not document the `git remote-testgit` commandJohannes Schindelin via GitGitGadget, Mar 25, 2019
  12. Ævar Arnfjörð BjarmasonMar 26, 2019
  13. Johannes SchindelinMar 27, 2019
  14. Johannes SchindelinMar 29, 2019
  15. 1/5 docs: move gitremote-helpers into section 7Johannes Schindelin via GitGitGadget, Mar 25, 2019
  16. 4/5 check-docs: do not expect guide pages to correspond to commandsJohannes Schindelin via GitGitGadget, Mar 25, 2019
  17. Johannes SchindelinMar 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.