Re: git bisect should return 1 when the first bad commit is found

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2019, 18:22 UTC
Message-ID: <xmqq5zp9wdjb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAC_CU1iWBCTt5jLQ0Zp2HoyA0oFgG3shDB2rLfOsmC+x67NdAw@mail.gmail.com>

Pedro Larroy <pedro.larroy.lists@gmail.com> writes:

Show 6 quoted lines

> I'm using git bisect, and for complex reasons I can't use git bisect
> run to drive the bisection. I don't think git bisect bad/good is
> returning a different status code when the first bad commit is found
> and this would be very useful to stop the driver of the bisection.
>
> What do you think?  Would such a change be acceptable?

Probably not.

A non-zero exit code would indicate that "git bisect" had trouble finding the next commit to check after being told 'good' (or 'bad'), which you wouldn't be able to tell from your "first bad one is found".

The 'first bad one' is not necessarily the HEAD when the bisect procedure finds it, so you'd have to read and parse "x is the first such commit" message anyway, no? And once you start parsing the message from 'git bisect', you should be able to tell between "please try this one, you have approximately 7 steps left" and "we found the first bad one, which is X", without relying on the exit status, no?