Re: [PATCH] git-gui: Call do_quit before destroying the main window

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2019, 17:50 UTC
Message-ID: <xmqq5zn8j25p.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <549ad583-5ca1-7096-f4ce-10e8a836f7f9@yadavpratyush.com>

Pratyush Yadav <me@yadavpratyush.com> writes:

Show 8 quoted lines

> So if I fork the project, will you pull from my fork? If yes, what
> exactly would I have to do? Make a set of changes and then ask on the
> list for you to pull from my fork?
>
> I am a relatively inexperienced programmer, and it feels like a kinda
> big responsibility that I'm not sure I am ready for. But maybe you can
> look at the changes from a high level POV before pulling, so there is
> someone sanity checking my changes.

This patch as a one-off thing may not be too bad, as it already had exposure to the list (and there probably are more people scanning it than it would have been if you silently made a pull request on GitHub, because they saw messages from me in this thread).

BUT.

If I make it a habit to pull git-gui stuff from random people who are not committed to and/or feel experienced enough for working on git-gui, the result would be even worse than taking patches on git-gui directly from the list. At least a patch on the list I can see how others react (or not react). On the other hand, I do not know how to interpret lack of comments from others on GitHub pull request---perhaps nobody thought it was a good change, perhaps nobody is paying attention to it, or what other possibilities there are.

So,... quite honestly, I'd rather not.