Re: [PATCH 3/3] git-p4: [usability] Show detailed help when parsing options fail
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 9, 2019, 22:24 UTC
- Message-ID
- <xmqq5zipt9w4.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <2a10890ef76697dbdd67b4c416077726100f88be.1575901009.git.gitgitgadget@gmail.com>
"Ben Keene via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 8 quoted lines
> From: Ben Keene <seraphire@gmail.com> > > When a user provides invalid parameters to git-p4, the program > reports the failure but does not provide the correct command syntax. > > Add an exception handler to the command-line argument parser to display > the command's specific command line parameter syntax when an exception > is thrown. Rethrow the exception so the current behavior is retained.
Makes sense, I guess.
I forgot to mention this, but from the titles of all three patches I would probably drop [usability] thing and downcase the first verb, e.g.
Subject: [PATCH 3/3] git-p4: show detailed help when parsing options fail
if I were writing these patches.
Thanks.