git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 17, 2019, 18:16 UTC
Message-ID
<xmqq5zieizrb.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<1d033204-80fd-25f8-3a80-0cb641953139@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 12 quoted lines
> On 12/17/2019 12:07 AM, Philippe Blain via GitGitGadget wrote:
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>> 
>> When giving a regex as parameter <start> or <end> in
>> `git log -L <start>,<end>:<file>`, or a function name in
>> `git log -L :<funcname>:<file>`, the given regex must match in the starting
>> revision, or else the command exits with a fatal error.
>> 
>> This is not obvious in the documentation, so add a note to that
>> effect.
>
> This seems helpful. Thanks.

Even when you specify <start> or <end> as a line number, they must exist in the starting revision or it would be a fatal error. If we are clarifying with this patch for completeness, I think we should also mention it together.

Or we could even drop the mention of regex and say <start> and <end>, regardless of how they are specified (including :<funcname> format), must exist in the starting revision.

Previous: Derrick StoleeNext: Philippe Blain
Message 9 of 18 in “Improve line log documentation”
  1. 0/2 Improve line log documentationPhilippe Blain via GitGitGadget, Dec 17, 2019
  2. 1/2 Documentation/git-log: document accepted line-log diff formatsPhilippe Blain via GitGitGadget, Dec 17, 2019
  3. SZEDER GáborDec 17, 2019
  4. Philippe BlainDec 18, 2019
  5. Derrick StoleeDec 17, 2019
  6. Philippe BlainDec 18, 2019
  7. 2/2 Documentation/git-log: mention that line-log regex must match in starting revisionPhilippe Blain via GitGitGadget, Dec 17, 2019
  8. Derrick StoleeDec 17, 2019
  9. Junio C HamanoDec 17, 2019
  10. Philippe BlainDec 18, 2019
  11. Derrick StoleeDec 18, 2019
  12. SZEDER GáborDec 18, 2019
  13. Junio C HamanoDec 18, 2019
  14. Philippe BlainDec 26, 2019
  15. SZEDER GáborDec 18, 2019
  16. 0/2 Improve line log documentationPhilippe Blain via GitGitGadget, Dec 26, 2019
  17. 1/2 doc: log, gitk: document accepted line-log diff formatsPhilippe Blain via GitGitGadget, Dec 26, 2019
  18. 2/2 doc: log, gitk: line-log arguments must exist in starting revisionPhilippe Blain via GitGitGadget, Dec 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.