Re: [PATCH v12 5/5] bugreport: add compiler info

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2020, 23:31 UTC
Message-ID: <xmqq5zecur7l.fsf@gitster.c.googlers.com>
In-Reply-To: <20200406224526.256074-6-emilyshaffer@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 5 quoted lines

> To help pinpoint the source of a regression, it is useful to know some
> info about the compiler which the user's Git client was built with. By
> adding a generic get_compiler_info() in 'compat/' we can choose which
> relevant information to share per compiler; to get started, let's
> demonstrate the version of glibc if the user built with 'gcc'.

This one is not about "what system are we running on", but more about "how were the various pieces of Git binaries the user has trouble running built?". While it may be useful to learn how "git bugreport" was compiled, the same question about the other binaries of Git (e.g. "git" itself, or "git ls-files" that is builtin) may have different answers. It should be fairly trivial to teach the "git" binaries (i.e. "git" itself plus builtins, and standalone subcommands like "git-remote-curl" and "git-bugreport") to report how they were built (e.g. with what library and compiler) by calling the helpers you added in [3/5] and [5/5] and once that is done, it would be straight-forward to teach "git bugreport" to collect properties of them by invoking them and reading their output via the run_command() interface, as I mentioned in my review on [3/5] earlire.

Thanks.