Re: [PATCH] t5534: split stdout and stderr redirection

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2020, 16:21 UTC
Message-ID: <xmqq5z7m3t2t.fsf@gitster.c.googlers.com>
In-Reply-To: <20201007001551.GA10178@danh.dev>

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

Show 18 quoted lines

> On 2020-10-06 12:11:00-0700, Junio C Hamano <gitster@pobox.com> wrote:
>> Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:
>> 
>> >  Arguably, I would say it's OK to change the:
>> >  	
>> >  	test_i18ngrep ! "gpg failed to sign"
>> >
>> >  to:
>> >
>> >  	! grep "gpg failed to sign"
>> >
>> >  since the latter will be correct even if GIT_TEST_GETTEXT_POISON=true
>> 
>> Is it because we haven't managed to translate this particular
>> message, or is it because we should never ever translate it perhaps
>> because the message is meant for machine consumption?
>
> We translated that message.

If so wouldn't the message shown under GIT_TEST_GETTEXT_POISON as something that does not even remotely resemble 'gpg failed to sign'?

... Ahh, hmm, cute but true. As long as our assertion is "the output should not have that message in it", '! grep' would do the job.

But that probably is not a good example to leave for others to copy and paste without thinking.

Thanks.