Re: [PATCH] Makefile: ASCII-sort += lists

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 8, 2020, 17:38 UTC
Message-ID: <xmqq5z7ky5wc.fsf@gitster.c.googlers.com>
In-Reply-To: <f0f1ef1f677133eabd1bce00c6cdbbcc6477f00b.1602142738.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> In 805d9eaf5e (Makefile: ASCII-sort += lists, 2020-03-21), the += lists
> in the Makefile were sorted into ASCII order. Since then, more out of
> order elements have been introduced. Resort these lists back into ASCII
> order.

OK. I tend to agree with the comment on Resort (by Dscho?? Sorry I forgot), so I'll locally do s/Resort/Sort/ while applying.

By the way, I have a mixed feelings about a patch like this very close to prerelease freeze. It is a good timing because not much _ought_ to be changing, and a small mechanical code churn like this one whose correctness is so obvious is easy to accept without risk of breaking things. But at the same time, it is distracting when we would rather see contributors' and reviewers' time spent on double checking that the changes made during this cycle did not introduce regressions.

Will queue.  Thanks.