Re: [PATCH] sequencer: fix gpg option passed to octopus merge

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2020, 16:56 UTC
Message-ID: <xmqq5z7fqt6k.fsf@gitster.c.googlers.com>
In-Reply-To: <6f650960-6b32-4be5-b909-86685c6ad5ea@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 9 quoted lines

> In run_git_commit() we do
>
> 	if (opts->gpg_sign)
> 		strvec_pushf(&cmd.args, "-S%s", opts->gpg_sign);
> 	else
> 		strvec_push(&cmd.args, "--no-gpg-sign");
>
> I'm not immediately clear why we pass --no-gpg-sign when
> opts->gpg_sign isn't set ...

Isn't it because there is a configuration that the &cmd may honor that forces gpg signing all the time?

> but it makes me wonder if we should be doing
> that here as well

Possibly.