Re: [BUG] In git-log, --name-status flag overrides the --patch flag

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2020, 19:09 UTC
Message-ID: <xmqq5z4vm0vt.fsf@gitster.c.googlers.com>
In-Reply-To: <X+CgJCj7/tadldUg@danh.dev>

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

Show 18 quoted lines

> On 2020-12-20 01:23:05-0300, Érico Rolim <erico.erc@gmail.com> wrote:
>> Hi!
>> 
>> When using the command
>> 
>>   git log --patch --name-status
>> 
>> It seems the name-status flag somehow overrides the patch flag, by which I mean
>> that I get the same output as simply running
>> 
>>   git log --name-status
>> 
>> It would be nice for the combination of these two flags to work, as it would
>> allow one to view both a summary of changed files as well as the changes
>> themselves, at the same time.
>
> I'm not arguing if this your expectation is make sense or not,
> however, the Documentation says something about "Show only"...

Perhaps the documentation would need to be clarified? I suspect this is not very useful combination [*1*] and if this were years ago, I would suggest making the command line error out, instead of silently ignore one and keep the other one in effect.

[Footnote]

*1* "--patch --stat --summmary" was designed as the standard "both a
    summary as well as the changes".