Re: [PATCH v3] fast-export: fix surprising behavior with --first-parent

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2021, 20:50 UTC
Message-ID: <xmqq5yrhptqk.fsf@gitster.g>
In-Reply-To: <CABPp-BF7Rg3NH3UBnyzD6c1vuFh+FNrNc8eRvUffqmaLppUPkw@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 8 quoted lines

>>      * Changed commit message to include the detailed description of the
>>        problem area as suggested by Elijah. I went back and forth with my
>>        self about whether the message needs some "lead in", but it ended up
>>        getting long without adding much.
>
> If it feels weird quoting someone else so extensively and just using
> their words for the commit message, we've used a "Commit-message-by:"
> trailer in the past; that could be useful here.

I do not mind tweaking the copy I already have with "Helped-by" myself, while ...

> This version looks good to me:
>
> Reviewed-by: Elijah Newren <newren@gmail.com>

... adding this one before merging the result to 'next'.

Thanks, both.