Re: [PATCH v2 0/3] tweaks to refs/debug.c

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 22, 2021, 21:54 UTC
Message-ID: <xmqq5yrgi9uw.fsf@gitster.g>
In-Reply-To: <pull.1163.v2.git.git.1640196714.gitgitgadget@gmail.com>

"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> these are two small commits that helped me while debugging reftable support
> for git.
>
> Han-Wen Nienhuys (3):
>   refs: pass gitdir to packed_ref_store_create
>   refs: print error message in debug output
>   refs: centralize initialization of the base ref_store.

Welcome to our "we cannot count to three" club ;-)

All three patches make sense to me. Especially the [3/3] has become much easier to understand.

Thanks, will queue.

Message 10 of 10 in “tweaks to refs/debug.c”

0/2 tweaks to refs/debug.cHan-Wen Nienhuys via GitGitGadget, Dec 21, 2021
1/2 refs: print error message in debug outputHan-Wen Nienhuys via GitGitGadget, Dec 21, 2021
2/2 refs: set the repo in debug_ref_store.baseHan-Wen Nienhuys via GitGitGadget, Dec 21, 2021
Junio C HamanoDec 22, 2021
Han-Wen NienhuysDec 22, 2021
0/3 tweaks to refs/debug.cHan-Wen Nienhuys via GitGitGadget, Dec 22, 2021
1/3 refs: pass gitdir to packed_ref_store_createHan-Wen Nienhuys via GitGitGadget, Dec 22, 2021
2/3 refs: print error message in debug outputHan-Wen Nienhuys via GitGitGadget, Dec 22, 2021
3/3 refs: centralize initialization of the base ref_store.Han-Wen Nienhuys via GitGitGadget, Dec 22, 2021
Junio C HamanoDec 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.