git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] tests: add LIBCURL prerequisite to tests needing libcurl

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 15, 2022, 21:08 UTC
Message-ID
<xmqq5yl1zlb1.fsf@gitster.g>
In-Reply-To
<220615.861qvpy8jq.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 14 quoted lines
>>> -if test -n "$NO_CURL"
>>> +if ! test_have_prereq LIBCURL
>>>  then
>>>  	skip_all='skipping test, git built without http support'
>>>  	test_done
>>
>> This is not strictly needed in "the most minimal fix possible", is
>> it?  Just checking.
>
> I figured if I was adding a $NO_CURL prereq I might as well change the
> only existing use of $NO_CURL to use it, which also assures the reader
> that our test suite is getting this from somewhere already.
>
> But I'll drop this in a re-roll.
No need.  It already is at the tip of 'master' applied directly.
Previous: Ævar Arnfjörð Bjarmason
Message 5 of 5 in “For v2.37.0: fix tests breaking with NO_CURL=Y”
  1. 0/1 For v2.37.0: fix tests breaking with NO_CURL=YÆvar Arnfjörð Bjarmason, Jun 15, 2022
  2. 1/1 tests: add LIBCURL prerequisite to tests needing libcurlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  3. Junio C HamanoJun 15, 2022
  4. Ævar Arnfjörð BjarmasonJun 15, 2022
  5. Junio C HamanoJun 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.