git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4205: don't exit test script on failure

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 2, 2022, 01:45 UTC
Message-ID
<xmqq5yeur32x.fsf@gitster.g>
In-Reply-To
<221202.86a646hdb6.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 7 quoted lines
> I think it's a productive comment on a patch to point out that it's the
> exact same change someone else has submitted independently before.
>
> In my mind that's better than a "LGTM" or "Reviewed-by". Those are both
> versions of "I looked over your work", but if you independently come up
> with the same thing that's usually a stronger sign that the proposed
> solution is a good one.
Not necessarily.

Past effort that did not fare well needs to be re-examined to make sure it was not picked up because it was crappy, because two people independently coming up with the same crappiness does not help us build more confidence. Instead of forcing other reviewers waste their time looking at older threads, it would help to explain what you find good in the patch you are reviewing.

Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 5 of 6 in “t4205: don't exit test script on failure”
  1. t4205: don't exit test script on failureRené Scharfe, Dec 1, 2022
  2. Ævar Arnfjörð BjarmasonDec 1, 2022
  3. Junio C HamanoDec 1, 2022
  4. Ævar Arnfjörð BjarmasonDec 2, 2022
  5. Junio C HamanoDec 2, 2022
  6. Junio C HamanoDec 3, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.