Re: [PATCH v2] usage: clarify --recurse-submodules as a boolean
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Emily Shaffer <nasamuffin@google.com> writes:
>
>> `git switch` `git checkout`, `git reset`, and `git read-tree` allow a
>
> Missing comma?
>
>> user to choose to recurse into submodules. All four of these commands'
>> short usage seems to indicate that `--recurse-submodules` should take an
>> argument. In practice, though, all four of these commands parse through
>> the same callback path:
>>
>> option_parse_recurse_submodules_worktree_updater(...) checks for
>> set/unset, or passes off to...
>> parse_update_recurse_submodules_arg(...), which is a straight handoff
>> to...
>> parse_update_recurse(...), which only accepts true or false.
>
> "true or false" -> "various forms of 'true' (e.g. on/1/yes) or 'false'"
>
>> So ultimately, it can only be true or false, unlike `git push
>
> Likewise. Here is a minimally touched up version I queued.
>
> Thanks.
> ...
Any updates on this topic?