Re: [PATCH v4] revision: add `--ignore-missing-links` user option

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2023, 19:16 UTC
Message-ID: <xmqq5y435obx.fsf@gitster.g>
In-Reply-To: <CAOLa=ZT_DVw4Na-rj4mk2ULkrqDyVP2_cOpgdLozFjn3RJbTvg@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 5 quoted lines

> I was thinking about this, but mostly didn't do this, because the
> interaction with `--missing` is only for non-commit
> objects. Because for missing commits, `--ignore-missing-links`
> skips the commit and the value of `--missing` doesn't make any
> difference.

Hmph, somehow that smells like an existing bug. So does the "trees are not shown by --missing=print, and show_object() is never called for missing objects unless they are blobs" you mention. When the user asks "instead of dying, list them so that I can ask around and fetch them to repair this repository", shouldn't we do just that?

I wonder if these bugs are something people may be taking advatage of and cannot be fixed retroactively? If we can fix these and nobody complains, that would give us the ideal outcome, I would think.

Thanks.