Re: [PATCH v4] tests: adjust whitespace in chainlint expectations
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 16 quoted lines
> Aside: I was rather surprised to see this output from git-am when applying v4:
>
> Applying: tests: adjust whitespace in chainlint expectations
> .git/rebase-apply/patch:205: new blank line at EOF.
> +
> .git/rebase-apply/patch:219: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
>
> But upon investigating the two "test" files in question,
> dqstring-line-splice.test and dqstring-no-interpolate.test, I recalled
> that I had to play tricks to escape the single-quote context created
> by the Makefile when generating t/chainlinttmp/tests in order to allow
> chainlint.pl to see a double-quoted string. So, the abovementioned
> blank lines are indeed expected output from chainlint.pl given the
> tricks played.
Thanks for being extra careful while reviewing.