git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/revert.c: refactor using an enum for cmd-action

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 11, 2024, 19:37 UTC
Message-ID
<xmqq5xzzhda6.fsf@gitster.g>
In-Reply-To
<1ed0e249-dab9-4cf3-9b76-c8797b97c9c5@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> I think ACTION_NONE was intended to covey that the user did not pass
> one of the OPT_CMDMODE() options like "--continue" as there isn't a
> "--start" option. I don't have a strong opinion between "_NONE" and
> "_START".

I agree with you why NONE is called as such. If "revert" does not take "--start" (I do not remember offhand), I would think it would be better to follow suit.

Previous: Michael Lohmann
Message 11 of 11 in “builtin/revert.c: refactor using an enum for cmd-action”
  1. builtin/revert.c: refactor using an enum for cmd-actionMichael Lohmann, Jan 11, 2024
  2. Phillip WoodJan 11, 2024
  3. builtin/revert.c: refactor using an enum for cmd-actionMichael Lohmann, Jan 11, 2024
  4. Junio C HamanoJan 11, 2024
  5. builtin/revert.c: refactor using an enum for cmd-actionMichael Lohmann, Jan 11, 2024
  6. Junio C HamanoJan 11, 2024
  7. Junio C HamanoJan 12, 2024
  8. Jeff KingJan 12, 2024
  9. Junio C HamanoJan 12, 2024
  10. Michael LohmannJan 12, 2024
  11. Junio C HamanoJan 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.