Re: What's cooking in git.git (Feb 2024, #05; Tue, 13)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2024, 16:57 UTC
Message-ID: <xmqq5xyrx9tg.fsf@gitster.g>
In-Reply-To: <CZ4WA9QJXMX2.3BK6C9ZGOSN7A@gmail.com>

"Ghanshyam Thakkar" <shyamthakkar001@gmail.com> writes:

> I see that it is already in 'next'. However, I have rerolled it for a
> single line change. If find it is worth it, here it is: 
> https://lore.kernel.org/git/20240213000601.520731-2-shyamthakkar001@gmail.com/

The usual procedure is that once a topic hits 'next', it gets improved only by piling incremental updates on top with explanation. The idea is: if all of us thought it has seen enough eyeballs and is good enough for 'next', yet we later find there was something we all missed, that is worth a separate explanation, e.g., "The primary motivation behind the series is still good, but for such and such reasons we missed this case we are fixing."

Unless it turns out that the approach was fundamentally wrong and such an incremental update boils down to almost reverting the earlier one entirely and replacing it with the newer one. In such a case, we do revert the earlier and replace it with the newer, in 'next'.

But as the development community members work across timezones on their own pace, mails cross and mistakes happen. I've reverted the merge of the previous one from 'next' and queued the new one (I do not recall offhand if the updated one is already in 'next', though).

Thanks.