Re: [PATCH 3/3] t-ctype: do one test per class and char

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 4, 2024, 18:46 UTC
Message-ID: <xmqq5xy1q1gp.fsf@gitster.g>
In-Reply-To: <ZeYUZZ6Z8VtYnBn7@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 14 quoted lines

> On 2024.03.02 23:00, René Scharfe wrote:
> ...
>> I was starting the programs from t/unit-tests/bin/ individually because
>> I didn't know 'make unit-tests' exists.  This is much nicer, thank you!
>> Especially after adding 'DEFAULT_UNIT_TEST_TARGET = unit-tests-prove' to
>> config.mak to complement the 'DEFAULT_TEST_TARGET = prove' I added long
>> ago.  It would be even nicer if the former was the default when the
>> latter is set.
>
> After js/unit-test-suite-runner [1] is merged, then using
> 'DEFAULT_TEST_TARGET = prove' will also run the unit tests alongside the
> shell test suite.
>
> [1] https://lore.kernel.org/git/cover.1708728717.git.steadmon@google.com/

Nice ;-).