Re: [GSoC][PATCH v2] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 2, 2024, 18:55 UTC
Message-ID: <xmqq5xtnsjxp.fsf@gitster.g>
In-Reply-To: <16e06a6d-5fd0-4132-9d82-5c6f13b7f9ed@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 5 quoted lines

>> +	}
> 	check_int(count, ARRAY_SIZE(key_val));
>
> to check that we iterate over all the entries as well as checking the
> size of the hashmap here.

I think check_int() macro wants the comparison operator in the middle, but other than that small typo, the suggestion sounds quite sensible. If the iterator does not yield anything, the current test would still pass.

Thanks.