git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] userdiff: add builtin diff driver for TypeScript language

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2024, 15:45 UTC
Message-ID
<xmqq5xt5bat7.fsf@gitster.g>
In-Reply-To
<20240716122112.zqauqgxmng2tk2j6@archP14s>
Matthew Hughes <matthewhughes934@gmail.com> writes:
> This needs some updates.
What does it mean?

The patterns that were posted were so broken that they are unusable and harm the users by giving misleading information?

Or do the patterns work just fine in basic or tutorial cases, but with more advanced or realistic uses of the language construct, they highlight wrong lines as the function header and/or split at wrong word boundaries that are obviously much less optimal than ideal that any human users would find questionable?

In the latter case, how far from the ideal are the decisions done by the current patterns, and what's the rough percentage of usual code we see in the real world, for which the current patterns do not work well?

What I am trying to gauge is if it is so broken that it should not exist (in other words, you regret sending the patch to the list before doing these updates), or is "already serviceable, but not perfect yet". Waiting for perfection takes forever. If the latter, letting the general public to use it to gather feedbacks by waiting for the dust to settle before making such updates is often better.

Previous: Matthew HughesNext: Matthew Hughes
Message 3 of 6 in “userdiff: add builtin diff driver for TypeScript language”
  1. userdiff: add builtin diff driver for TypeScript languageMatthew Hughes via GitGitGadget, Jul 15, 2024
  2. Matthew HughesJul 16, 2024
  3. Junio C HamanoJul 16, 2024
  4. Matthew HughesJul 16, 2024
  5. Junio C HamanoJul 16, 2024
  6. Johannes SixtJul 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.