Re: [PATCH v2 2/3] transport: introduce transport_has_remote_bundle_uri()

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 26, 2024, 15:25 UTC
Message-ID: <xmqq5xssyy2z.fsf@gitster.g>
In-Reply-To: <CAOLa=ZTuM9XsroDKizvtOB0d1mJ4t8ffi6_bMuX+R8qzUEW6Rw@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 13 quoted lines

>> diff --git a/transport.c b/transport.c
>> index 12cc5b4d96..1a7d86fa40 100644
>> --- a/transport.c
>> +++ b/transport.c
>> @@ -1536,7 +1536,7 @@ int transport_fetch_refs(struct transport *transport, struct ref *refs)
>>  	return rc;
>>  }
>>
>> -int transport_get_remote_bundle_uri(struct transport *transport)
>> +static int transport_get_remote_bundle_uri(struct transport *transport)
>>
>
> Why make it static?

The reason is rather well described in the proposed log message, I think.

Show 10 quoted lines

>> + * bundle URI(s) are received from the server.
>> + * Populates "struct transport"'s "bundles" and "got_remote_bundle_uri".
>>   */
>> -int transport_get_remote_bundle_uri(struct transport *transport);
>> +int transport_has_remote_bundle_uri(struct transport *transport);
>>
>
> Shouldn't this now be renamed to `transport_has_bundle_uri`? Earlier, we
> were 'getting' bundle URIs from the remote. Now, we are abstracting that
> away and simply asking, 'do we have bundle URIs'.

A good question.