Re: [PATCH v3 0/7] reftable: stop using Git subsystems

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2024, 01:09 UTC
Message-ID: <xmqq5xoibtjd.fsf@gitster.g>
In-Reply-To: <CAOLa=ZSbj966S+kXtyr-1iJ3eqnDvDt=vN1kfPsSAFaAENmOJw@mail.gmail.com>

karthik nayak <karthik.188@gmail.com> writes:

Show 24 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
>
> [snip]
>
>> Range-diff against v2:
>> 1:  2b7d4e28529 = 1:  2b7d4e28529 reftable/system: move "dir.h" to its only user
>> 2:  38cfe85bf5b = 2:  38cfe85bf5b reftable: explicitly handle hash format IDs
>> 3:  745c1a070dd = 3:  745c1a070dd reftable/system: stop depending on "hash.h"
>> 4:  7782652b975 = 4:  7782652b975 reftable/stack: stop using `fsync_component()` directly
>> 5:  b15daefbc83 ! 5:  430be1045d6 reftable/system: provide thin wrapper for tempfile subsystem
>>     @@ reftable/system.h: license that can be found in the LICENSE file or at
>>      +
>>      +/*
>>      + * Rename the temporary file to the provided path. The temporary file must be
>>     -+ * active. Return 0 on success, a reftable error code on error.
>>     ++ * active. Return 0 on success, a reftable error code on error. Deactivates the
>>     ++ * temporary file.
>>      + */
>>      +int tmpfile_rename(struct reftable_tmpfile *t, const char *path);
>>
>> 6:  83949837a29 = 6:  b9ffdc605b9 reftable/stack: drop only use of `get_locked_file_path()`
>> 7:  80fe5bc5e10 = 7:  e1ac1cc2e67 reftable/system: provide thin wrapper for lockfile subsystem
>
> Post my previous review, this range diff looks good. Thanks

Thanks, both.  Queued.