git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Would it be possible to add an option to disable validating submodule paths?

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 7, 2025, 23:25 UTC
Message-ID
<xmqq5xmqqk9j.fsf@gitster.g>
In-Reply-To
<Z320RGb0tqNyvvxt@tapette.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 7 quoted lines
> Since this is a defense-in-depth change and it seems to have broken a
> reasonable workflow, I think adding a config option for this would be
> reasonable.  We've recently had some discussions on trying to limit the
> defense-in-depth measures we implement on the security list in the
> interests of allowing better discussion and feedback on the main list
> and avoiding regressions in people's workflows, and I think your email
> lends support to that approach.

Thanks; I was writing my own response and said pretty much the same thing as above, before I saw this message.

Show 5 quoted lines
> I'm not presently planning to add such an option, but it shouldn't be
> too hard to add a global variable for that (or maybe something under
> struct repository) that's updated when parsing config, and then check it
> in `validate_submodule_path`.  We'd need docs for that option as well,
> but that would probably be it if someone wanted to do so.

Sounds reasonable, but I wonder how this would interact with bootstrapping. Should it be configured in ~/.gitconfig, possibly with [includeIf] to specify the directory you'd store a bunch of repositories you clone from outside, or something? I guess "git clone" without "--recurse-submodules" is simple enough to be used for bootstrapping, and then the configuration can be set at the top-level superproject after cloning but before "submodule init".

Previous: brian m. carlsonNext: Vadim Zeitlin
Message 3 of 7 in “Would it be possible to add an option to disable validating submodule paths?”
  1. Vadim ZeitlinJan 7, 2025
  2. brian m. carlsonJan 7, 2025
  3. Junio C HamanoJan 7, 2025
  4. Re[2]: Would it be possible to add an option to disable validating submodule paths?Vadim Zeitlin, Jan 7, 2025
  5. Junio C HamanoJan 8, 2025
  6. Re[2]: Would it be possible to add an option to disable validating submodule paths?Vadim Zeitlin, Jan 8, 2025
  7. submodule: Add a config option to skip path validationVadim Zeitlin, Jul 28, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.