git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 'seen' branch fails to build

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 10, 2025, 00:16 UTC
Message-ID
<xmqq5xew58vq.fsf@gitster.g>
In-Reply-To
<92c8c9eb-91de-48c6-88ac-7d5583cc766a@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 5 quoted lines
> See commit 456a265746 ("diff: --no-index should ignore the worktree",
> 2025-08-07) in the 'jc/diff-no-index-in-subdir' branch.
>
> In order to get it to build, I just did:
> ...

Thanks for noticing and reporting. I'd save the translators by reusing the message used already elsewhere.

 builtin/diff.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git c/builtin/diff.c w/builtin/diff.c
index 3eb4cbb057..0b23c41456 100644
--- c/builtin/diff.c
+++ w/builtin/diff.c
@@ -497,7 +497,8 @@ int cmd_diff(int argc,
 	 * prefix.
 	 */
 	if (no_index && prefix) {
-		chdir(prefix);
+		if (chdir(prefix))
+			die(_("cannot come back to cwd"));
 		prefix = NULL;
 	}
 
Previous: Ramsay Jones
Message 2 of 2 in “'seen' branch fails to build”
  1. Ramsay JonesAug 9, 2025
  2. Junio C HamanoAug 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.