Re: What's cooking in git.git (May 2026, #03)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 15, 2026, 01:46 UTC
- Message-ID
- <xmqq5x4pe970.fsf@gitster.g>
- In-Reply-To
- <CALE2CrTea19qHKbhQK8V+uQJgh5GdT+8ia1q2jwr+hf546fnaQ@mail.gmail.com>
Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:
Show 5 quoted lines
> My thinking was mainly that git stash show normally omits untracked > changes, while --include-untracked consults the additional untracked > parent of the stash commit. > > I did not see existing coverage specifically checking that behavior,
Ah, OK. Please more explicitly state that it is filling a gap in test coverage in the proposed log message; it would have helped to sell the patch better. Adding even more when we already have adequate coverage is one thing, covering the cases we had no coverage is totally different matter.
Thanks.