git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] git-remote-testgit: fix race when spawning fast-import

From
Junio C Hamano <junio@pobox.com>
Date
Apr 23, 2012, 02:40 UTC
Message-ID
<xmqq4nsbmapw.fsf@junio.mtv.corp.google.com>
In-Reply-To
<20120422203058.GA17290@padd.com>
Pete Wyckoff <pw@padd.com> writes:
> Clemens suggested disabling the test by default, as I've done
> here.  I think it would be okay to remove it entirely, too.
Ok.
Show 7 quoted lines
> +# Generally, skip this test.  It demonstrates a now-fixed
> +# race in git-remote-testgit, but is too slow to leave in
> +# for general use.
> +test_expect_success DEBUG_TESTGIT_RACE 'racily pushing to local repo' '
> +	cp -a server server2 &&
> +	git clone "testgit::${PWD}/server2" localclone2 &&
> +	test_when_finished "rm -rf server2 localclone2" &&

Shouldn't test_when_finished come before these two commands? Otherwise server2 or localclone2 directories will be left behind when they fail before control reaches it...

Previous: Pete WyckoffNext: Pete Wyckoff
Message 25 of 26 in “master: t5800-remote-helpers.sh hangs on test "pulling from remote remote"”
  1. Stefano LattariniApr 14, 2012
  2. Clemens BuchacherApr 14, 2012
  3. Stefano LattariniApr 15, 2012
  4. Clemens BuchacherApr 15, 2012
  5. Stefano LattariniApr 15, 2012
  6. Clemens BuchacherApr 15, 2012
  7. Stefano LattariniApr 15, 2012
  8. Clemens BuchacherApr 15, 2012
  9. Stefano LattariniApr 15, 2012
  10. Clemens BuchacherApr 15, 2012
  11. Stefano LattariniApr 15, 2012
  12. Clemens BuchacherApr 15, 2012
  13. Sverre RabbelierApr 17, 2012
  14. Pete WyckoffApr 19, 2012
  15. Stefano LattariniApr 15, 2012
  16. Pete WyckoffApr 21, 2012
  17. Clemens BuchacherApr 21, 2012
  18. Pete WyckoffApr 22, 2012
  19. git-remote-testgit: fix race when spawning fast-importPete Wyckoff, Apr 21, 2012
  20. Clemens BuchacherApr 21, 2012
  21. Pete WyckoffApr 22, 2012
  22. Clemens BuchacherApr 22, 2012
  23. Junio C HamanoApr 22, 2012
  24. [PATCHv2] git-remote-testgit: fix race when spawning fast-importPete Wyckoff, Apr 22, 2012
  25. Junio C HamanoApr 23, 2012
  26. Pete WyckoffApr 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.