Re: [PATCH 3/5] checkout --to: no auto-detach if the ref is already checked out

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2014, 16:08 UTC
Message-ID: <xmqq4mwxgbjq.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACsJy8A3+9Rzz7ZEC3jgz0aQngT06Xi85gf6u2KS8VQUqkChvg@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 14 quoted lines

> On Thu, Jul 31, 2014 at 1:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Michael J Gruber <git@drmicha.warpmail.net> writes:
>>
>>> As an error message that is completely sufficient.
>>>
>>> The advice messages are meant to teach the user about the normal parts
>>> of the toolchest to use in a situation of "conflict", aren't they?
>>
>> Not really.  They are to remind (to those who learned but forgot)
>> and to hint (to those who haven't realized they have things to learn
>> in this area).  Wall of text that tries to do more than that, like
>> "teaching", risks not getting read by anybody.
>
> Last call to all. Keep this 'advice' or drop it?

I think you quoted what I needed to say already so I won't repeat myself. Earlier you said:

    If you have two checkouts associated to the same repo, "git
    checkout foo" on one checkout when "foo" is held by another
    checkout would cause the same error. I'll need to think of a
    better name than advice.checkoutTo.

and I agree; the patch needs rerolling in any case.