Re: [PATCH] date.c: phrase a comment gender neutral

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2014, 20:03 UTC
Message-ID: <xmqq4mtwwa1n.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1416338668-30683-1-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> When looking for suitable functions to print dates,
> I found this gem. Let's make it gender neutral as
> nowadays people get upset by this gender debate.

For some time I used to use "she/her" on Mondays, Wednesdays and Fridays and "he/his" on other days to balance them, and you are seeing the artifact of that.

Some people might feel that we would be better off using "they" all the time, but IMO it's such a minor thing that once it _is_ in the tree, it's not really worth the patch noise to go and fix it up.

Show 19 quoted lines

>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  date.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/date.c b/date.c
> index 59dfe57..19fb439 100644
> --- a/date.c
> +++ b/date.c
> @@ -732,7 +732,7 @@ int parse_expiry_date(const char *date, unsigned long *timestamp)
>  		/*
>  		 * We take over "now" here, which usually translates
>  		 * to the current timestamp.  This is because the user
> -		 * really means to expire everything she has done in
> +		 * really means to expire everything they have done in
>  		 * the past, and by definition reflogs are the record
>  		 * of the past, and there is nothing from the future
>  		 * to be kept.