Re: feature request: excluding files/paths from "git grep"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2015, 19:17 UTC
Message-ID: <xmqq4mq7jh9d.fsf@gitster.dls.corp.google.com>
In-Reply-To: <54F08989.2050504@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 18 quoted lines

> Junio C Hamano venit, vidit, dixit 26.02.2015 21:59:
>
>> So that does not sound to me a summary of the discussion at all.
>
> Well, your conditional
>
>> I do not recall its conclusion, but it it were "Yes, that is what it
>> means", then it might be reasonable to:
>> 
>>  - have "git grep" ignore paths marked with -diff by default
>>    (perhaps "-a" option to disable, just like GNU)
>> 
>>  - have "git grep" pay attention to diff.textconv and search in the
>>    result of textconv filter.
>
> and Jeff's "Yes" on that condition certainly read like that to me: Make
> "git grep" react to "diff", "-diff" attributes in the same way as "git
> diff".

Ah, OK, I missed that flow of thought.

I read the conclusion as "_if_ using "diff" attributes is enough for this purpose, then there is no code to be written ... but 'grep' and 'diff' may want to be different."

Once we know if they do *not* want to be different, I agree that it may make things more consistent to turn --textconv on for binary files when running grep.