Re: [PATCH V2/RFC][GSoC] diff-no-index: transform "$directory $file" args to "$directory/$file $file"

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 26, 2015, 22:58 UTC
Message-ID: <xmqq4mp7xt5k.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAHLaBN+nE9tmGMdJM65V-bONKe8CE9PZ1Ottc1R9D=Pm0X7k_g@mail.gmail.com>

Yurii Shevtsov <ungetch@gmail.com> writes:

Show 13 quoted lines

> git diff --no-index refuses to compare if args are directory and file,
> instead of usual diff.
>
> Now git diff --no-index modifies args, if they're directory and file,
> and diffs files, as usual diff does.
>
> Changes are done in diff_no_index().
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Yurii Shevtsov <ungetch@gmail.com>
> ---
>  diff-no-index.c |   31 +++++++++++++++++++++++++++++--
>  1 files changed, 29 insertions(+), 2 deletions(-)

This round looks sensible. Good catch to notice that POSIX wants you to append not just the "path to the file", but the basename of the file, to the directory name.

I didn't try your patch, but I wouldn't be surprised if it passed the tests in the patches I wrote last night in the $gmane/266315 thread ;-).

Good luck with your GSoC application.